Implement second-order convex regions #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
enhancement
sethrj
force-pushed
the
more-convex-regions
branch
from
d39222a to
74bc044
Compare
|
@elliottbiondo Thanks for reviewing the convex region work! This PR is the next on the list. |
elliottbiondo
approved these changes
Feb 27, 2024
| { | ||
| insert_surface(Sense::outside, PlaneZ{-hh_}); | ||
| insert_surface(Sense::inside, PlaneZ{hh_}); | ||
| insert_surface(CCylZ{radius_}); |
There was a problem hiding this comment.
Why aren't you inserting an interior and exterior bounding box for the cylinder region?
There was a problem hiding this comment.
Ah, the "known closed" quadric/planar surfaces (axis aligned cylinders, spheres, and planes) automatically generate the correct bounding boxes using the surface clipper. I'll add a note to the convex region builder pointing out the relationship.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #1119. This implements:
There is a bugfix in the deduplication code (adding
+ 0.0to clear any potential negative zero flag) to prevent simplified surfaces from having negative zeroes. This will make output more robust and hopefully do the same if-ffast-mathis enabled.