Support safety and reentrant boundaries for multi-universe ORANGE #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottbiondo
changed the title
sethrj
reviewed
Mar 5, 2024
elliottbiondo
commented
Mar 7, 2024
|
@sethrj you can remove draft and begin your review |
sethrj
reviewed
Mar 7, 2024
test/orange/data/testem3.org.omn
Outdated
|
|
||
| !#### LEVEL 0 UNIVERSE ####! | ||
|
|
||
| [UNIVERSE][SHAPE=cuboid full] |
There was a problem hiding this comment.
To be consistent with the gdml and "flat" geometry, could you rename this calorimeter, and add a cell called world that's outside it and inside a box with halfwidth 24?
{
'_type': "box",
'widths': [48, 48, 48],
'name': "world",
}There was a problem hiding this comment.
Sure, noting that the world cell will have an internal region, meaning supports_safety_ will now be false
There was a problem hiding this comment.
I don't know if its worth keeping the original geom as well in order to test that this returns true for it:
supports_safety_
= std::all_of(
host_data.simple_units[AllItems<SimpleUnitRecord>()].begin(),
host_data.simple_units[AllItems<SimpleUnitRecord>()].end(),
[](SimpleUnitRecord const& su) { return su.simple_safety; })
&& host_data.rect_arrays.empty();
There was a problem hiding this comment.
Model updated to include world
sethrj
added
enhancement
sethrj
changed the title
|
@sethrj this is ready for another look |
sethrj
pushed a commit
to sethrj/celeritas
that referenced
this pull request
Jun 20, 2024
…leritas-project#1140) * Add support for reentrant boundary crossing with multi-universe tracking * Fixing set_dir such that it queries the correct universe for finding the normal * Update safety distance for multiple levels * Add testem3 style unit test for safety distance calculation * Fix safety distance on multiple levels * Address comments from merge request * TestEM3 model updated to include world volume
sethrj
pushed a commit
that referenced
this pull request
Jun 21, 2024
) * Add support for reentrant boundary crossing with multi-universe tracking * Fixing set_dir such that it queries the correct universe for finding the normal * Update safety distance for multiple levels * Add testem3 style unit test for safety distance calculation * Fix safety distance on multiple levels * Address comments from merge request * TestEM3 model updated to include world volume
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds support for reentrant cross_boundary() calls when a particle resides on boundary between geometric universes. In addition, safety distance calculations are updated to find the minimum safety distance over multiple levels. A TestEM3 unit test is added, using universes. This version of the this test problem supports simple safety. Finally, a bug in UnitInserter is fixed, in which volume flags were being erroneously unset.