Add proto-universe and CSG Unit construction #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
enhancement
elliottbiondo
approved these changes
Mar 14, 2024
|
|
||
| //---------------------------------------------------------------------------// | ||
| /*! | ||
| * Construct a universe for building ORANGE geometry. |
| /*! | ||
| * Get a list of all daughter protos. | ||
| */ | ||
| auto UnitProto::daughters() const -> VecProto |
There was a problem hiding this comment.
Not sure if this is enough work to cross into "calc_daughters"
There was a problem hiding this comment.
Maybe... maybe get_daughters? I'll revisit this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next-to-last step for programmatically building an ORANGE geometry from CSG objects. It defines a "proto-universe" interface for defining individual universes (aka "scenes") and building them. For testing and external integration with SCALE, the
UnitProtoclass has a helper function for returning a CsgUnit which makes testing a cinch.The following PR will take the constructed CSG unit, build a UniverseInput, and actually construct an OrangeParams object for tracking.