Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import WLS data for optical photons #1165

Merged
merged 7 commits into from
Mar 25, 2024
Merged

Import WLS data for optical photons #1165

merged 7 commits into from
Mar 25, 2024

Conversation

stognini
Copy link
Member

This PR is tied to issue #886 and imports optical photon wavelength shifting (WLS) data from Geant4.

@stognini stognini requested review from whokion and sethrj March 25, 2024 14:22
@stognini stognini added enhancement New feature or request external Dependencies and framework-oriented features labels Mar 25, 2024
whokion
whokion approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@whokion whokion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stognini for adding WLS material properties. All look good except the unit for the WLS component which is unitless, which need to be changed.

app/celer-dump-data.cc Outdated Show resolved Hide resolved
src/celeritas/io/ImportOpticalMaterial.hh Outdated Show resolved Hide resolved
sethrj
sethrj approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@sethrj sethrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@sethrj sethrj merged commit dbbc4f0 into celeritas-project:develop Mar 25, 2024
25 of 26 checks passed
@stognini stognini deleted the import-wls branch March 25, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whokion whokion whokion approved these changes

@sethrj sethrj sethrj approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request external Dependencies and framework-oriented features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stognini @sethrj @whokion