Add optical collector for generating scintillation and Cerenkov distribution data #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add optical state and params data for generating distributions - Refactor Cerenkov pre-generator to allocate distribution on stack - Add optical collector class - Add pre-generator action - Update optical test base and Cerenkov test
amandalund
added
enhancement
amandalund
force-pushed
the
optical-collector
branch
from
0f7b1c4 to
a632535
Compare
sethrj
reviewed
Apr 3, 2024
|
Thanks @sethrj, yeah I can definitely move the pre-gen changes into a separate PR. |
amandalund
commented
Apr 4, 2024
amandalund
force-pushed
the
optical-collector
branch
from
8a93acf to
ba566e4
Compare
|
@sethrj I'm happy to split this up further if you'd like since it's still a little large (maybe into actions/executors and collector/test). |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optical collector class to build the pre- and post-step actions for creating the optical distribution data. A test runs the stepping loop with these actions added and checks the generated distributions.