Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.4.3 #1216

Merged
merged 4 commits into from
May 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions app/celer-sim/Transporter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ auto Transporter<M>::operator()(SpanConstPrimary primaries)
}
++result.num_step_iterations;
result.num_steps += track_counts.active;
result.num_aborted = track_counts.alive + track_counts.queued;
result.max_queued = std::max(result.max_queued, track_counts.queued);
};

Expand Down Expand Up @@ -136,9 +135,8 @@ auto Transporter<M>::operator()(SpanConstPrimary primaries)
}
if (CELER_UNLIKELY(interrupted()))
{
CELER_LOG_LOCAL(error)
<< "Caught interrupt signal: aborting transport "
"loop";
CELER_LOG_LOCAL(error) << "Caught interrupt signal: aborting "
"transport loop";
interrupted = {};
break;
}
Expand All @@ -153,6 +151,7 @@ auto Transporter<M>::operator()(SpanConstPrimary primaries)
}
}

result.num_aborted = track_counts.alive + track_counts.queued;
result.num_track_slots = stepper_->state().size();
return result;
}
Expand Down
44 changes: 44 additions & 0 deletions doc/appendix/release-history/v0.4.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,50 @@
.. SPDX-License-Identifier: CC-BY-4.0


.. _release_v0.4.3:

Version 0.4.3
=============

*Released 2024/05/01*

Version 0.4.3 is a bugfix and minor feature update to Celeritas.

- Adds diagnostic output for ``celer-sim`` even when not recording all steps
- Fixes a sampling error for keV electron ionization
- Builds with ROCm 5.7.1
- Builds with Geant4 10.5–10.7, 11.1.0


New features
------------

* Add JSON test comparator to improve testing reliability *(@sethrj, #1115)*
* Add spack-based workflow to add all supported Geant4 versions to CI *(@sethrj, #1149)*
* Add always-on basic diagnostics to celer-sim *(@amandalund, #1214)*

Reviewers: @amandalund *(1)*, @drbenmorgan *(1)*, @sethrj *(1)*

Bug fixes
---------

* Fix Moller-Bhahba energy distribution *(@amandalund, #1138)*
* Fix Geant4 build from 10.5–10.7 and example build for 11.1 onward *(@sethrj, #1152)*
* Fix missing Werror in build-fast workflow *(@sethrj, #1141)*
* Fix build error with Geant4@11.1.0 *(@amandalund, #1199)*

Reviewers: @sethrj *(2)*, @whokion *(1)*, @drbenmorgan *(1)*, @amandalund *(1)*

Documentation improvements
--------------------------

* Update Frontier installation *(@sethrj, #1208)*

Reviewers: @esseivaju *(1)*

**Full Changelog**: https://github.com/celeritas-project/celeritas/compare/v0.4.2...v0.4.3


.. _release_v0.4.2:

Version 0.4.2
Expand Down
3 changes: 2 additions & 1 deletion scripts/cmake-presets/frontier.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@
"displayName": "Frontier release mode",
"inherits": [".ndebug", ".base"],
"cacheVariables": {
"BUILD_SHARED_LIBS": {"type": "BOOL", "value": "OFF"}
"BUILD_SHARED_LIBS": {"type": "BOOL", "value": "OFF"},
"CMAKE_INSTALL_PREFIX": "/lustre/orion/world-shared/hep143/celeritas/develop"
}
},
{
Expand Down
13 changes: 6 additions & 7 deletions scripts/env/frontier.sh
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
#!/bin/sh -e

PROJID=hep143
_celer_view=${PROJWORK}/${PROJID}/opt-view
_tool_view=/ccs/proj/${PROJID}/opt-view
_conda=/ccs/proj/${PROJID}/conda-frontier
_worldwork=${WORLDWORK}/${PROJID}
_ccsproj=/ccs/proj/${PROJID}

module load PrgEnv-amd/8.5.0 cpe/23.12 amd/5.7.1 craype-x86-trento \
libfabric/1.15.2.0 miniforge3/23.11.0
Expand All @@ -27,10 +26,10 @@ export CC=${CRAYPE_DIR}/bin/cc
# module load craype-accel-amd-gfx90a

# Set up celeritas
export SPACK_ROOT=/ccs/proj/hep143/spack
export PATH=${_celer_view}/bin:${_tool_view}/bin:${_conda}/bin:$PATH
export CMAKE_PREFIX_PATH=${_celer_view}:${CMAKE_PREFIX_PATH}
export MODULEPATH=${PROJWORK}/${PROJID}/share/lmod/linux-sles15-x86_64/Core:${MODULEPATH}
export SPACK_ROOT=${_ccsproj}/spack
export PATH=${_worldwork}/opt-view/bin:${_ccsproj}/opt-view/bin:${_ccsproj}/conda-frontier/bin:$PATH
export CMAKE_PREFIX_PATH=${_worldwork}/opt-view:${CMAKE_PREFIX_PATH}
export MODULEPATH=${_worldwork}/share/lmod/linux-sles15-x86_64/Core:${MODULEPATH}

# Set up Geant4 data
module load geant4-data/11.0
Expand Down
Loading