Fix trapezoid construction for negative phi and older Geant4 #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amandalund
reviewed
May 8, 2024
mrguilima
previously requested changes
May 8, 2024
|
@mrguilima I've removed the validation checking from phi:
If the value were part of the shape's data, we should regularize it so that there's a one-to-one correspondence between values and shapes produced. However, since phi just gets preprocessed into the same points, there's no need to impose extra effort on the user (e.g. it's ok if they want to specify the rotation as 3/4 turn instead of -1/4 turn). |
|
Is the proposed removal of validation satisfactory @mrguilima ? |
|
Yes, it looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @mrguilima for pointing out that there was an error in the calculation.
Also fixes #1223 (comment) .