Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactoring/niceties for upcoming polycone work #1246

Merged
merged 5 commits into from
May 22, 2024
Merged

Minor refactoring/niceties for upcoming polycone work #1246

merged 5 commits into from
May 22, 2024

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented May 21, 2024

  • Add structured binding support to celeritas::array by implementing tuple methods
  • Move monotonic_decreasing and VectorUtils to corecel and genericize the underlying algorithm along the lines of "any of"
  • Expose geometry tolerance to surface builder so that we can use "soft equivalence" for twisted faces

@sethrj sethrj added core Software engineering infrastructure minor Minor internal changes or fixes labels May 21, 2024
@sethrj sethrj requested review from mrguilima and esseivaju May 21, 2024 13:38
@sethrj sethrj mentioned this pull request May 22, 2024
Merged
@sethrj sethrj force-pushed the polycone-prereq branch from 975bfc5 to c6ca8e8 Compare May 22, 2024 08:55
@sethrj sethrj requested a review from elliottbiondo May 22, 2024 09:09
@sethrj sethrj merged commit 2da4678 into celeritas-project:develop May 22, 2024
28 checks passed
@sethrj sethrj deleted the polycone-prereq branch May 22, 2024 13:56
esseivaju
esseivaju reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@esseivaju esseivaju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had these two minor comments that I didn't publish since the CI was failing.

src/corecel/cont/Array.hh Show resolved Hide resolved
src/corecel/grid/VectorUtils.hh Show resolved Hide resolved
@sethrj
Copy link
Member Author

sethrj commented May 22, 2024

Ah sorry bout that! Will include in follow on.

sethrj added a commit to sethrj/celeritas that referenced this pull request May 23, 2024
@sethrj
Address @esseivaju feedback from celeritas-project#1246
b267411
sethrj added a commit that referenced this pull request May 23, 2024
@sethrj
Implement polycone (#1247)
08f509f 
* Allow degenerate cylinder as part of cone

* Add string view signature for build_intersect_region

* Implement polycone

* Fix and slightly refactor polycone

* Add parens

* Address feedback

* Address @esseivaju feedback from #1246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esseivaju esseivaju esseivaju left review comments

@elliottbiondo elliottbiondo elliottbiondo approved these changes

@mrguilima mrguilima Awaiting requested review from mrguilima

Assignees
No one assigned
Labels
core Software engineering infrastructure minor Minor internal changes or fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sethrj @elliottbiondo @esseivaju