Refactor optical data to use extensible params/states #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
core
sethrj
changed the title
sethrj
force-pushed
the
core-data-optical
branch
from
a9707a4 to
efc6b24
Compare
sethrj
force-pushed
the
core-data-optical
branch
2 times, most recently
from
e632ce6 to
a95300d
Compare
sethrj
force-pushed
the
core-data-optical
branch
from
a95300d to
aa62614
Compare
amandalund
approved these changes
Jun 18, 2024
| storage_->obj.state<MemSpace::native>( | ||
| core_state.stream_id(), core_state.size()), | ||
| storage_->size[core_state.stream_id().get()]}}; | ||
| scintillation_->device_ref(), state.store.ref()}}; |
There was a problem hiding this comment.
Is this missing the buffer size?
Suggested change
| scintillation_->device_ref(), state.store.ref()}}; | |
| scintillation_->device_ref(), state.store.ref(), state.buffer_size}}; |
There was a problem hiding this comment.
Goodness, why did that compile, and even worse how does the test pass? 👀 Good catch. I've checked the other call signatures.
esseivaju
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the optical collector to use "user" params and state rather than a state store.