Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate ROOT files during CI testing #1287

Merged
merged 15 commits into from
Jun 24, 2024

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Jun 22, 2024

This updates the Geant4 configuration file for the four-steel-slabs ROOT input used by the UrbanMsc testing so that the committed data matches the regenerated data. To ensure consistency in the future (i.e. regenerating the file won't break the tests) the CI now regenerates (but does not commit!) the files as part of testing.

I also noticed during testing that the neutron XS environment variable isn't being passed to the tests; so this fixes that and adds an additional check to fail the CI if the environment varibles are missing inside the test.

@sethrj sethrj added the documentation Documentation, examples, tests, and CI label Jun 22, 2024
@sethrj sethrj requested review from amandalund and stognini June 22, 2024 13:18
Copy link
Contributor

@amandalund amandalund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sethrj!

test/celeritas/phys/ProcessBuilder.test.cc Outdated Show resolved Hide resolved
@sethrj sethrj enabled auto-merge (squash) June 24, 2024 13:35
@sethrj sethrj merged commit d856538 into celeritas-project:develop Jun 24, 2024
29 checks passed
@sethrj sethrj deleted the root-file-ci branch July 23, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation, examples, tests, and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants