Refactor types to reduce duplication and cyclic dependencies #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
core
esseivaju
reviewed
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While rearranging some IO subroutines I inadvertently caused a circular dependency between collection/ldg/span/quantity/opaqueID. This moves all LDG related definitions and specializations to the "most downstream" compared to the primary implementation. I also reduced some type duplication in
geocel/orangeby defining Real2/Size2 ingeocel/Types.hh. This also fixes an inadvertent find/replace error in GeoParamsInterface in #1000 .