Reduce string duplication from assertion messages #1338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by @esseivaju 's example in #1325 , this defines external constant strings for "runtime error" types to both reduce library size and to avoid "magic constants" (i.e. requiring that special string values in one file match string values in another).
HIP/frontier (ORANGE ndebug):
CUDA/wildstyle (ORANGE reldeb):
Unfortunately I'm not able to use
static inline constexpr
for the CUDA/HIP printf statements:see this llvm bug report for details.