Refactor rejection sampling using a helper class #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
physics
``` Internal error: assertion failed at: "overload.c", line 28946 in deduce_class_template_args 1 catastrophic error detected in the compilation of "/__w/celeritas/celeritas/src/celeritas/em/model/MollerBhabhaModel.cu". ```
amandalund
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Thanks @sethrj! Hopefully this helps prevent any more rejection sampling bugs going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defines a
RejectionSamplerclass that can be used as a more intuitive replacement forBernoulliDistributionduring rejection sampling loops. Instead of "accepting" when the sample is within bounds (necessitating an easy-to-miss negation in thewhilecondition) we "reject" by returning true unless the sampled value is accepted.