-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor user manual #1363
Refactor user manual #1363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* TODO this should be precomputed and used as part of the "applicability" per | ||
* particle type, not included in the interactor. See celeritas#907 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we do that if it depends on the incident particle energy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "applicability" for interactions should have a lower bound for the incident particle energy based on conservation rules etc. So, given a particle type and the electron cutoff for a material, we should be able to solve for the lowest incident muon energy that creates an electron higher than the secondary cutoff. Right? The reason we can't do this now is because we don't have per-material applicability (#907).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, that's right. Actually, looking again I think the max secondary energy might already be used to limit the cross section/energy loss calculation in Geant4, in which case we shouldn't need to do anything except remove the (unnecessary) check in the interactor.
This breaks apart several of the long Sphinx RST files into smaller ones (so that instead of being organized according to the code directories, it's broken apart by subject matter). It flattens the structure to make it easier to jump to and read certain parts of the documentation. Finally it improves usability of the within-document sidebar.
Latest manual: https://sethrj.github.io/celeritas/user/index.html