Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept single CsgTree from stdin #1366

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

esseivaju
Copy link
Contributor

The use case for reading from stdin is to print a single tree dumped by to_json_string. The list check only makes sense when reading from a .csg.json file where we can have multiple csg universes.

@esseivaju esseivaju added bug Something isn't working minor Minor internal changes or fixes labels Aug 15, 2024
@esseivaju esseivaju requested a review from sethrj August 15, 2024 19:10
scripts/user/orange-csg-to-dot.py Outdated Show resolved Hide resolved
scripts/user/orange-csg-to-dot.py Outdated Show resolved Hide resolved
Copy link
Member

@sethrj sethrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for government work!

@sethrj sethrj merged commit 2d87efb into celeritas-project:develop Aug 16, 2024
27 of 29 checks passed
@esseivaju esseivaju deleted the fix-orange-csg-to-dot branch August 16, 2024 20:23
@sethrj sethrj added app Application front ends and removed bug Something isn't working labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Application front ends minor Minor internal changes or fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants