Properly clear state counters and data for reuse #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a helper method to reset state data * Add a generic function to fill a collection with a sequence * Move track shuffle util to global/detail
amandalund
force-pushed
the
fix-state-reuse
branch
from
101ce16 to
2295467
Compare
sethrj
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an unsual case for celer-sim when multiple events are run one at a time on a single stream and
max_stepsis specified (unlikely to be done in practice, but how we run our CPU app test). Because the core state counters, track status, and vacancies are not reset between events, stale state data is reused in the next event. This adds a helper method to reset the state data, as well as: