Sample scintillation photons individually #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To simplify, remove particle scintillation for now since it's not implemented.
sethrj
added
physics
stognini
reviewed
Aug 19, 2024
stognini
reviewed
Aug 19, 2024
amandalund
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the scintillation photon generator to create a single photon at a time by sampling from material yields instead of splitting the selected photons among them. It also fixes an error in the sampling (which assumed that component index for a material was the same as the component ID).
It keeps us from losing "stratified sampling" of the original implementation but it no longer unfairly rounds.
I refactored some of the data structures and builders to make this happen, and to reduce the amount of work I've removed the unused scintillate-by-particle construction code (which @stognini added and I believe @whokion mildly objected to because it may not be needed). The data structures and related import code are still there; we can either remove those at some future point or re-add the by-particle construction and implement sampling by particle.