Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action for generating scintillation photons from distributions #1414

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

amandalund
Copy link
Contributor

Mostly boilerplate and mostly identical to the Cerenkov actiion.

@amandalund amandalund added enhancement New feature or request physics Particles, processes, and stepping algorithms labels Sep 18, 2024
@amandalund amandalund requested a review from sethrj September 18, 2024 22:08
Copy link
Member

@sethrj sethrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. For future work we should define a template interface that handles the common parts of the generators.

Also I was thinking while writing the optical stepping loop: we really should have the generator actions be optical not core, since we might want to generate more initializers without allocating the extra space for them. (I.e., we could get away with a relatively small number of initializers and optical track slots while still having a lot of EM tracks.) For now of course let's just allocate as many initializers as we need.

@amandalund
Copy link
Contributor Author

Agreed, I originally had them in the optical loop, but after our discussion in #1386 (comment) moved them to the core loop so we can access all the necessary data (but figured we'd be doing quite a bit of refactoring).

@sethrj
Copy link
Member

sethrj commented Sep 19, 2024

Right, I'm so forgetful 🫠

@sethrj sethrj enabled auto-merge (squash) September 19, 2024 18:18
@sethrj sethrj merged commit c4806e3 into celeritas-project:develop Sep 19, 2024
31 checks passed
@amandalund amandalund deleted the scint-gen-action branch September 19, 2024 20:30
@amandalund amandalund mentioned this pull request Oct 17, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request physics Particles, processes, and stepping algorithms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants