Add slot particle diagnostic #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test summary 3 249 files 5 047 suites 3m 41s ⏱️ Results for commit 4286b59. ♻️ This comment has been updated with latest results. |
sethrj
force-pushed
the
slot-particle-diagnostic
branch
from
9776414 to
969096d
Compare
|
Super cool! I was wishing we had something like this to see how the separation evolves over time for some of the benchmark problems. Will take a look soon. |
|
Yeah! After this gets merged I was going to run it (but I'm happy to let you!) to make pretty plots for the upcoming presentations. |
|
Just as a side note, I ran the same problem on GPU and got identical behavior. One of these days we should do a more thorough GPU/CPU equivalence comparison. |
amandalund
approved these changes
Sep 27, 2024
sethrj
force-pushed
the
slot-particle-diagnostic
branch
from
bc4a4b9 to
179dffd
Compare
sethrj
force-pushed
the
slot-particle-diagnostic
branch
from
179dffd to
d00d93d
Compare
amandalund
reviewed
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a class that extends @amandalund 's neat ASCII art in #1322 to exporting particle IDs at every step for postprocessing.
TestEM3 demo (from Amanda's unit test):
Celer-g4 offloading unit test (without partitioning) showing concatenated events:
