Add a hack to override ORANGE max intersections/faces #1430
Conversation
sethrj
added
minor
Test summary 3 264 files 5 062 suites 3m 42s ⏱️ Results for commit c43ff2f. ♻️ This comment has been updated with latest results. |
| << mfi_hack_envname << "='" << mfi << "'"; | ||
|
|
||
| ForceMax result; | ||
| static std::regex const mfi_regex{R"re(^(\d+),(\d+)$)re"}; |
There was a problem hiding this comment.
In the context of this being a presumably temporary hack I don't know if this matters, but it the regex validation is complex enough to get its own function in anonymous namespace.
There was a problem hiding this comment.
Yeah this option shouldn't live long (the "cheat" itself isn't tested anywhere except by me manually for our regression problems). The regex ^(\d+),(\d+)$ isn't that complicated (whole text, capture two nonnegative integers separated by a comma) but perhaps it's harder to read because of the literal R"re()re" string.
This should allow us to restore the performance of TestEM3 temporarily, although we should disclose that this hack is being used when we present our test problems.
|
OK, using the "flat" file changes the results because of MSC: But the throughput for the "identical geometry in memory" goes up: |
See #1334 . This should allow us to restore the performance of TestEM3 temporarily, although we should disclose that this hack is being used when we present our test problems.
This will only help if all the visited volumes have fewer faces/intercepts than the given value: otherwise it will crash.
I'm going to test this before merging.