Improve single-event mode in accel
#1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The track ID for "primary" is inconsistent with the track counter and can cause duplicate track IDs.
sethrj
added
bug
sethrj
changed the title
accel
pcanal
reviewed
Oct 15, 2024
amandalund
approved these changes
Oct 15, 2024
Test summary 3 300 files 5 097 suites 3m 30s ⏱️ Results for commit 4d16cbf. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Oct 15, 2024
| step.reseed(UniqueEventId{123}); | ||
| step(make_span(primaries)); | ||
| EXPECT_EQ(TrackStatus::alive, sim.status()); | ||
| EXPECT_EQ(TrackId{0}, sim.track_id()); |
There was a problem hiding this comment.
Should we extent the test to other ids than 0?
There was a problem hiding this comment.
I don't think it's necessary, since there's nothing special about track ID 0. We've got other tests to make sure that the code treats all track slots fairly, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follow-on to discussions in #1447 adds a non-synchronizing "fill" call to the track slot IDs (and also removes the synchronization in the RNG reseed). It also marks as "deprecated" the
max_num_eventssetting in Celeritas. Finally, it also tests reproducibility using the full stepper.