Require less ancient CUDA architecture and OpenMP implementation #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test summary 4 428 files 6 854 suites 6m 51s ⏱️ Results for commit bc7ef01. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Jan 17, 2025
pcanal
reviewed
Jan 17, 2025
amandalund
reviewed
Jan 17, 2025
sethrj
changed the title
sethrj
added
core
pcanal
approved these changes
Jan 18, 2025
sethrj
added a commit
that referenced
this pull request
Jan 21, 2025
* Use OpenMP on windows build * Remove atomic support for ancient architectures * Add macro for atomics * Use signed integer to make windows happy * Use track parallelism * Require OpenMP 3 * Use llvm runtime for msvc * add debug message * Revert "add debug message" * Revert signed integers * Turn openmp off for windows * Override cache variables rather than advising user * Remove MSVC code * Address pcanal feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a CMake-based check that OpenMP support conforms to 3.0 and above (spec released in 2008). It also removes support for ancient CUDA cards (older than 2016) and simplifies some of the atomic macros. As part of the CMake check, the "invalid option" now updates the CMake Cache rather than suggesting a variable change, so it's likely a reconfigure will pass.