Seltzer-Berger positron correction fix #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add max number of iterations in SB rejection loop for sampling gamma energy - Update geant exporter to use both SB and relativistic brems and relativistic pair production
amandalund
added
bug
sethrj
reviewed
Apr 5, 2022
Also: - Revert SB energy distribution rejection loop - Add to SBPositronXsCorrector documentation
sethrj
approved these changes
Apr 9, 2022
|
Thanks to you for catching on to the other bug! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe we were missing a factor of two pi in the SB positron cross section correction factor -- added here. I've also:
Capped the number of iterations in the SB rejection loop for sampling the gamma energy at 100 (same as Geant4)