Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "background" volume support to ORANGE #530

Merged
merged 8 commits into from
Oct 27, 2022

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Oct 19, 2022

This adds the ability to define a "default" volume as the exclusion of all other defined regions. In Geant4-like geometries this will be the typical use case.

@sethrj sethrj added the enhancement New feature or request label Oct 19, 2022
@sethrj
Copy link
Member Author

sethrj commented Oct 26, 2022

Ping @elliottbiondo and @paulromano for a review please!

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping @sethrj. I just have a few questions:

src/orange/Data.hh Show resolved Hide resolved
src/orange/detail/UnitInserter.cc Show resolved Hide resolved
src/orange/detail/UnitInserter.cc Outdated Show resolved Hide resolved
@sethrj sethrj merged commit 4be09b0 into celeritas-project:master Oct 27, 2022
@sethrj sethrj deleted the orange-background branch October 27, 2022 08:40
@sethrj sethrj added orange Work on ORANGE geometry engine and removed geometry labels Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request orange Work on ORANGE geometry engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants