Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import a few more EM parameters from Geant4 #703

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Import a few more EM parameters from Geant4 #703

merged 2 commits into from
Mar 28, 2023

Conversation

amandalund
Copy link
Contributor

  • Import LowestElectronEnergy and rename eloss_calc_limit
  • Import MSC range factor, safety factor, and lambda limit

@amandalund amandalund added minor Minor internal changes or fixes external Dependencies and framework-oriented features labels Mar 28, 2023
@amandalund amandalund requested a review from sethrj March 28, 2023 00:39
sethrj
sethrj approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@sethrj sethrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks basically perfect. We might want to start making a list of "things we want to access from geant4 classes but can't" since I can make a pull request at some point... assuming the EM parameters are constant and not being overridden by individual models is hopefully good enough for now 😅

@sethrj sethrj merged commit e59f495 into celeritas-project:develop Mar 28, 2023
@sethrj sethrj added enhancement New feature or request and removed minor Minor internal changes or fixes labels Mar 28, 2023
@amandalund amandalund deleted the import-params branch March 28, 2023 18:31
@amandalund
Copy link
Contributor Author

@sethrj I started a list here, we can add to it as others come up.

@sethrj sethrj linked an issue Mar 28, 2023 that may be closed by this pull request
Import "lowest electron energy" cutoff from Geant4 #652
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethrj sethrj sethrj approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request external Dependencies and framework-oriented features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import "lowest electron energy" cutoff from Geant4
2 participants
@amandalund @sethrj