Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation failure mode when sphinx is unavailable #712

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Apr 3, 2023

No description provided.

sethrj added 2 commits April 3, 2023 12:23
Don't build PDFs unless sphinx is available. Fix the sphinx rebuild logic.
@sethrj sethrj added documentation Documentation, examples, tests, and CI minor Minor internal changes or fixes labels Apr 3, 2023
@sethrj sethrj requested review from amandalund and mrguilima April 3, 2023 16:27
@mrguilima
Copy link
Contributor

The message is very clear about missing sphinx.
I could not install it without system priviledges (Fermilab machine). So I ran it also in my laptop, with sphinx installed. Then I got a 76-pages document Celeritas.pdf. Nice!
Thanks @sethrj !

@sethrj sethrj merged commit 370d04d into celeritas-project:develop Apr 5, 2023
@sethrj sethrj deleted the doc-tweaks branch April 5, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation, examples, tests, and CI minor Minor internal changes or fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants