-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new capabilities to run CMS with sensitive detectors #713
Conversation
If VecGeom has multiple volume names, we get an exception: ``` issued by : celeritas/ext/VecgeomParams.cc:134 volume 'ebalgo_EBRY_01_refl' is not unique ```
The last round of fixes will conflict with #557 . |
@sethrj I have a compilation error with the latest update:
|
Sorry @whokion , that's what I get for only building one test and the app. Everything now builds on my laptop, hope that fixes it! |
Just for records, there are still two known issues running demo-geant-integration on GPU (even though this MR may not be directly responsible for these failures):
|
I am also still hitting And probably not related to this PR, but the following tests are now failing for me (vecgeom, debug on, reldeb build): The following tests FAILED:
90 - celeritas/global/Stepper:TestEm3NoMsc.* (Failed)
142 - app/demo-loop (Failed)
144 - app/demo-geant-integration (Subprocess aborted) |
@amandalund Yes, this was with CPU just on my laptop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes and improvements @sethrj!
@whokion @amandalund With the new
/setup/stripGDMLPointers true
option, I can now successfully run CMS run 3 through the standalone app: see https://github.com/celeritas-project/benchmarks/blob/main/full-cms-test/demo-geant-cpu.mac .There are still a bunch of warning messages such as:
but these names are only inside of "union" solids, and I think they're just an artifact of how VecGeom builds temporary volumes that seem not to show up in the actual geometry.