Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a VecGeom+RelWithDebInfo+debug build to the CI #715

Merged
merged 9 commits into from
May 10, 2023
Merged

Add a VecGeom+RelWithDebInfo+debug build to the CI #715

merged 9 commits into from
May 10, 2023

Conversation

amandalund
Copy link
Contributor

See if we can reproduce the test failures on the CI.

sethrj
sethrj reviewed Apr 6, 2023
View reviewed changes
Copy link
Member

@sethrj sethrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that the reldeb failure in the stepper gives the same result as the flaky HIP one...

src/celeritas/phys/ParticleData.hh Outdated Show resolved Hide resolved
src/celeritas/track/detail/ProcessSecondariesLauncher.hh Outdated Show resolved Hide resolved
@amandalund
Copy link
Contributor Author

Interesting that the reldeb failure in the stepper gives the same result as the flaky HIP one...

Is it the same? It looks like it's failing here with fewer than expected step iterations/average steps per primary and more than expected with HIP.

@sethrj
Copy link
Member

sethrj commented Apr 6, 2023

Ok I didn't look carefully enough 😆

This was referenced Apr 6, 2023
Closed
Merged
@sethrj sethrj added the minor Minor internal changes or fixes label Apr 7, 2023
@sethrj sethrj mentioned this pull request Apr 12, 2023
Merged
@amandalund amandalund mentioned this pull request Apr 21, 2023
Merged
@sethrj sethrj added this to the v0.3.0 milestone May 4, 2023
@sethrj
Copy link
Member

sethrj commented May 4, 2023

@amandalund Let's try this one again after #743 is merged.

@sethrj sethrj marked this pull request as ready for review May 10, 2023 15:45
@sethrj
Copy link
Member

sethrj commented May 10, 2023

Good news @amandalund , reldeb seems to work now! 😓/😅

@amandalund
Copy link
Contributor Author

Hope it stays that way! 🤞

@sethrj sethrj merged commit d3e50cc into celeritas-project:develop May 10, 2023
@amandalund amandalund deleted the vecgeom-reldeb-ci branch May 10, 2023 16:41
@sethrj sethrj added the external Dependencies and framework-oriented features label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethrj sethrj sethrj approved these changes

Assignees
No one assigned
Labels
external Dependencies and framework-oriented features minor Minor internal changes or fixes
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@amandalund @sethrj