Fix step limiter when losing all energy over a step #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This assigns the "range" limiter when a particle loses all energy over a step (even when it's not marked as range-limited) and has no at-rest interaction. The "discrete" process will be incorrectly selected otherwise. This isn't a probelm currently because we also filter on track.status(), but we want the action ID to be consistent.
sethrj
added
bug
|
Thanks! Caught it with the upcoming execute/launch refactor 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assigns the "range" limiter when a particle loses all energy over a step (even when it's not marked as range-limited) and has no at-rest interaction.
The "discrete" process will be incorrectly selected otherwise. This isn't a probelm currently because we also filter on track.status(), but we want the action ID to be consistent.