Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bremsstrahlung process construction based on Geant4PhysicsOptions #811

Merged
merged 4 commits into from
Jun 9, 2023

Conversation

stognini
Copy link
Member

@stognini stognini commented Jun 8, 2023

Previously the constructor of BremsstralunghProcess would only construct models based on the LPM suppression and combined bremsstrahlung model flags, and therefore Seltzer-Berger was never selected as the only model. This is fixed by cascading the BremsModelSelection enum into ProcessBuilder and finally BremsstrahlungProcess.

@stognini stognini requested a review from sethrj June 8, 2023 18:46
@stognini stognini added bug Something isn't working physics Particles, processes, and stepping algorithms labels Jun 8, 2023
Copy link
Member

@sethrj sethrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks stefano!

@stognini
Copy link
Member Author

stognini commented Jun 8, 2023

Thanks. I'll keep an eye on the CI to be sure all is well.

@sethrj sethrj merged commit 85c614c into celeritas-project:develop Jun 9, 2023
@stognini stognini deleted the fix-brems branch June 9, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working physics Particles, processes, and stepping algorithms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants