Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screening_factor to ImportEmParameters #840

Merged
merged 5 commits into from
Jun 30, 2023

Conversation

stognini
Copy link
Member

This PR adds the G4EmParameters::ScreeningFactor parameter to ImportData as it is a requirement for the Coulomb scattering process.

@stognini stognini requested review from sethrj, whokion and hhollenb June 30, 2023 13:57
@stognini stognini added the io label Jun 30, 2023
@stognini
Copy link
Member Author

Note: I avoided updating the existing test ROOT file (and any test) since this double is already initialized as 1 by default, exactly as in G4EmParameters.

@sethrj sethrj added the minor Minor internal changes or fixes label Jun 30, 2023
Co-authored-by: Seth R. Johnson <johnsonsr@ornl.gov>
@hhollenb
Copy link
Contributor

Looks good, thanks

@sethrj sethrj merged commit 44dea69 into celeritas-project:develop Jun 30, 2023
@stognini stognini deleted the import-screenfact branch June 30, 2023 19:55
@sethrj sethrj added physics Particles, processes, and stepping algorithms minor Minor internal changes or fixes and removed minor Minor internal changes or fixes labels Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Minor internal changes or fixes physics Particles, processes, and stepping algorithms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants