Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement remaining quadric surfaces #867

Merged
merged 18 commits into from
Aug 10, 2023

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Jul 28, 2023

This implements the remaining quadric surfaces in ORANGE.

@sethrj sethrj added the orange Work on ORANGE geometry engine label Jul 28, 2023
@sethrj sethrj requested a review from elliottbiondo July 28, 2023 20:29
@sethrj sethrj added the enhancement New feature or request label Jul 30, 2023
@sethrj
Copy link
Member Author

sethrj commented Aug 8, 2023

@elliottbiondo Reviewing this isn't the highest priority, but I'd appreciate if you can make the time to review the PR this week. Thanks!

Copy link
Contributor

@elliottbiondo elliottbiondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @sethrj, just a few minor things

src/orange/surf/ConeAligned.hh Outdated Show resolved Hide resolved
src/orange/surf/ConeAligned.hh Show resolved Hide resolved
src/orange/surf/ConeAligned.hh Outdated Show resolved Hide resolved
src/orange/surf/ConeAligned.hh Outdated Show resolved Hide resolved
src/orange/surf/Plane.hh Show resolved Hide resolved
src/orange/surf/SimpleQuadric.hh Outdated Show resolved Hide resolved
src/orange/surf/SimpleQuadric.hh Show resolved Hide resolved
src/orange/surf/SurfaceIO.cc Show resolved Hide resolved
@sethrj sethrj requested a review from elliottbiondo August 10, 2023 13:23
@sethrj sethrj merged commit ddf0d65 into celeritas-project:develop Aug 10, 2023
@sethrj sethrj deleted the orange-surfaces branch August 10, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request orange Work on ORANGE geometry engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants