Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export full Celeritas version string as well as defaulted CMake variables #870

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Aug 1, 2023

This adds provenance to the CMake configuration when using a non-release version of Celeritas. It also records all the scoped settings that Celeritas uses internally (e.g. shared library construction).

@sethrj sethrj added core Software engineering infrastructure minor Minor internal changes or fixes labels Aug 1, 2023
@sethrj sethrj requested a review from pcanal August 1, 2023 13:06
@sethrj sethrj added this to the v0.3.1 milestone Aug 2, 2023
@sethrj sethrj requested a review from drbenmorgan August 2, 2023 15:38
@sethrj
Copy link
Member Author

sethrj commented Aug 2, 2023

@drbenmorgan Since Philippe is out for a bit and I'd like to merge this for 0.3.1, could you please take a quick look? Thanks!

Copy link
Contributor

@drbenmorgan drbenmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, all looks good so LGTM!

@sethrj sethrj merged commit 105ef79 into celeritas-project:develop Aug 2, 2023
@sethrj sethrj deleted the cmake-vars branch August 2, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Software engineering infrastructure minor Minor internal changes or fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants