-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement surface translation and transformation #887
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
enhancement
New feature or request
orange
Work on ORANGE geometry engine
labels
Aug 10, 2023
sethrj
force-pushed
the
orange-translator
branch
from
August 11, 2023 02:51
db87a8b
to
981fcae
Compare
sethrj
changed the title
Add utility for converting surfaces via translations
Add surface promotion, translation, transformation
Aug 13, 2023
sethrj
force-pushed
the
orange-translator
branch
from
August 13, 2023 18:00
14397ee
to
fd339a3
Compare
sethrj
force-pushed
the
orange-translator
branch
from
August 16, 2023 12:30
93264f5
to
fdb78a9
Compare
sethrj
changed the title
Add surface promotion, translation, transformation
Implement surface translation and transformation
Aug 16, 2023
sethrj
force-pushed
the
orange-translator
branch
from
August 22, 2023 14:24
fdb78a9
to
5039c70
Compare
@elliottbiondo Thanks for reviewing the surface promotion branch; this one is now ready for review. |
elliottbiondo
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds function-like helper classes that do type-safe promotions of one surface type to another via translations and transformations. It will be used for constructing surfaces from shapes.