Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement surface translation and transformation #887

Merged
merged 7 commits into from
Aug 23, 2023

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Aug 10, 2023

This adds function-like helper classes that do type-safe promotions of one surface type to another via translations and transformations. It will be used for constructing surfaces from shapes.

@sethrj sethrj added enhancement New feature or request orange Work on ORANGE geometry engine labels Aug 10, 2023
@sethrj sethrj requested a review from elliottbiondo August 10, 2023 19:20
@sethrj sethrj force-pushed the orange-translator branch from db87a8b to 981fcae Compare August 11, 2023 02:51
@sethrj sethrj changed the title Add utility for converting surfaces via translations Add surface promotion, translation, transformation Aug 13, 2023
@sethrj sethrj force-pushed the orange-translator branch from 14397ee to fd339a3 Compare August 13, 2023 18:00
@sethrj sethrj marked this pull request as draft August 16, 2023 12:25
@sethrj sethrj force-pushed the orange-translator branch from 93264f5 to fdb78a9 Compare August 16, 2023 12:30
@sethrj sethrj removed the request for review from elliottbiondo August 16, 2023 12:34
@sethrj sethrj changed the title Add surface promotion, translation, transformation Implement surface translation and transformation Aug 16, 2023
@sethrj sethrj force-pushed the orange-translator branch from fdb78a9 to 5039c70 Compare August 22, 2023 14:24
@sethrj sethrj marked this pull request as ready for review August 22, 2023 14:24
@sethrj
Copy link
Member Author

sethrj commented Aug 22, 2023

@elliottbiondo Thanks for reviewing the surface promotion branch; this one is now ready for review.

@sethrj sethrj requested a review from elliottbiondo August 22, 2023 14:34
Copy link
Contributor

@elliottbiondo elliottbiondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor suggestions

src/orange/surf/ConeAligned.cc Outdated Show resolved Hide resolved
src/orange/MatrixUtils.cc Show resolved Hide resolved
src/orange/MatrixUtils.cc Show resolved Hide resolved
src/orange/MatrixUtils.cc Show resolved Hide resolved
src/orange/MatrixUtils.hh Show resolved Hide resolved
src/orange/surf/SurfaceTransformer.cc Outdated Show resolved Hide resolved
src/orange/surf/SurfaceTransformer.cc Outdated Show resolved Hide resolved
src/orange/surf/SurfaceTranslator.hh Outdated Show resolved Hide resolved
@sethrj sethrj merged commit e7fee62 into celeritas-project:develop Aug 23, 2023
@sethrj sethrj deleted the orange-translator branch August 23, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request orange Work on ORANGE geometry engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants