Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: fix missing include from #849 #898

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

stognini
Copy link
Member

@stognini stognini commented Aug 16, 2023

This fixes a missing header error in BIHUtils.hh caused by a forward declaration on macOS (Xcode 14.2, command line tools 2395) that results in:

celeritas/src/orange/detail/BIHUtils.hh:21:25: error: implicit instantiation of undefined template 'std::vector<celeritas::BoundingBox<float>>'
    CELER_EXPECT(!bboxes.empty());
                        ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/usr/include/c++/v1/iosfwd:259:28: note: template is declared here
class _LIBCPP_TEMPLATE_VIS vector;

@stognini stognini requested a review from sethrj August 16, 2023 14:11
@stognini stognini added the minor Minor internal changes or fixes label Aug 16, 2023
@sethrj sethrj changed the title Fix BIHUtils.hh forward declaration build error on macOS Hotfix: fix missing include from #849 Aug 16, 2023
@sethrj sethrj merged commit e16e928 into celeritas-project:develop Aug 16, 2023
@stognini stognini deleted the bihutils-fixup branch August 16, 2023 17:20
@sethrj sethrj added the orange Work on ORANGE geometry engine label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Minor internal changes or fixes orange Work on ORANGE geometry engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants