Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ROOT-based event exporter #900
Add ROOT-based event exporter #900
Changes from all commits
3eff886
a591721
6a919c6
c7039fa
389d5cb
9fdd0c5
b514630
58a32be
5365993
bc4d486
d822921
c14d2fb
b0e9f43
8db8f19
2ba1132
2b68f96
473b5c8
95d6885
e0bd0ab
5b5340e
0bfede8
3ac3ced
9f99cff
798b407
47c7618
ea48c6a
b5fa3d9
1ec6e33
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add another
ScopedRootErrorHandler
here too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on how often we write a non-dictionary ROOT file it might be h
so that you can make a local
RootLeafReader read_leaf{ttree_.get()}; read_leaf("pos", p.pos);
etc.Probably not worth it for this small file but something to keep in mind.