Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect ROOT event writer to accel and reader to celer-sim #904

Merged
merged 7 commits into from
Aug 25, 2023
Merged

Connect ROOT event writer to accel and reader to celer-sim #904

merged 7 commits into from
Aug 25, 2023

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Aug 24, 2023

  • Add the ability to offload to ROOT from accel
  • Fix the offload keyword and a Geant4 integer overflow problem in celer-g4
  • Add the ability to generate events from a .root file in celer-sim

@sethrj sethrj added enhancement New feature or request external Dependencies and framework-oriented features app Application front ends labels Aug 24, 2023
@sethrj sethrj requested review from amandalund and stognini August 24, 2023 16:58
amandalund
amandalund approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@amandalund amandalund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @sethrj!

app/celer-g4/GlobalSetup.cc Outdated Show resolved Hide resolved
@stognini
Copy link
Member

Thanks @sethrj . Looks great.

@sethrj sethrj merged commit 41188ca into celeritas-project:develop Aug 25, 2023
@sethrj sethrj deleted the root-accel branch August 25, 2023 17:53
@sethrj sethrj removed the external Dependencies and framework-oriented features label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stognini stognini stognini approved these changes

@amandalund amandalund amandalund approved these changes

Assignees
No one assigned
Labels
app Application front ends enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sethrj @stognini @amandalund