Fix ORANGE bounding box bumping to be consistent with tracking tolerances #940
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Particles in EMPIRE were getting lost while crossing the$z=0$ plane because they didn't register as being in the bounding box on the other side. This is because $O(10^{-12})$ . We should be using the same bump behavior as in the BumpCalculator: each box coordinate is pushed outward by
nextafter(0f, -inff)
gives a value of-1e-45f
whereas it's reasonable and expected for the particles themselves to be bumped onmax(abs_tol, rel_tol * fabs(value))
.Instead of bumping outward by the width, we bump outward by the local value, since semi-infinite bounding boxes are not uncommon.