-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate ORANGE geometry on insertion #956
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
enhancement
New feature or request
core
Software engineering infrastructure
orange
Work on ORANGE geometry engine
labels
Sep 23, 2023
@sethrj did you intend to commit the regenerated json files to this branch? Seems like that should be a separate PR. |
This reverts commit 169a47f.
Good point @elliottbiondo . I'll open it separately. It shouldn't affect the deduplication... |
amandalund
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @sethrj!
elliottbiondo
approved these changes
Sep 27, 2023
sethrj
added
performance
Changes for performance optimization
and removed
core
Software engineering infrastructure
orange
Work on ORANGE geometry engine
labels
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds deduplication for ORANGE parameter data. It uses the new deduplicating collection builder to reuse identical spans of data for surfaces, logic definitions, volume ID ranges, etc.
In the hex array test, the following simplifications occur:
so mostly the logic and local surface IDs because so many hexes have the same definition.