Enable tracking through rectangular arrays #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
enhancement
sethrj
changed the title
sethrj
requested changes
Oct 11, 2023
Comment on lines
+958
to
+959
| TrackerVisitor visit_tracker{params_}; | ||
| return visit_tracker( |
There was a problem hiding this comment.
I wonder if it's worth having a template<class F> auto visit_tracker(F&&, UniverseId) const; (and same for visit_transform)?
There was a problem hiding this comment.
You mean something like:
template<class F> decltype(auto) OrangeTrackView::visit_tracker(F&& f, UniverseId uid)
{
TrackerVisitor visit{params_};
return visit(f, uid);
}
?
There was a problem hiding this comment.
@sethrj, I tried the code above, but I am getting type deduction errors, despite this the same API as what is done within TrackerVisit. The rest of this PR is good to go.
There was a problem hiding this comment.
Thanks for trying that out. We can simplify the code in the future if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR modifies OrangeTrackView to use the TrackerVisitor added in #959. This change does not impart any significant overhead, as evidenced by the plot below; running with pseudo array with and without static dispatch has no appreciable effect on timing.