Make einfo compatible with inspect (fixes #176) #392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libraries like
sentry
orbetter-exceptions
will fail while traversing exception chains withgetframeinfo
like this:As mentioned in #176, we can not inherit from
types.Traceback
and friends, but it's possible to override__class__
which will make theisinstance
check pass. This is also used internally by Python'sunittest.mock
module.An alternative approach could be to use a meta class and implement
__subclasscheck__
1, but that felt too involved.Footnotes
https://docs.python.org/3/reference/datamodel.html#class.__subclasscheck__ ↩