Readded binary .mo files #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last year with commit 079b2f0 .mo files have been excluded from repo with .gitignore which leads defacto to disabling all translations.
Although excluding binary in general is a good idea, this might not apply for reusable apps like django or celery.
As support for my opinion I like to point to the repos of django itself and drf:
rest_framework/locale/de/LC_MESSAGES
django/contrib/admin/locale/de/LC_MESSAGES
A alternative would be to compile the message during package installation e.g.
msgfmt --check-format -f -o django.mo django.poThat would be nice to follow the "no binary" approach but I haven't saw it in the wild for django apps yet, maybe because of depency issues.
In this pull request I readded the compiled .mo files, updated .gitignore and took some care of .po formatting
@auvipy if you are taking care of this request again: Sorry I didn't notice last years change earlier