Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix apicheck CI task and add additional testing for PyPy 3.9 #616

Merged
merged 5 commits into from
Dec 19, 2022
Merged

Fix apicheck CI task and add additional testing for PyPy 3.9 #616

merged 5 commits into from
Dec 19, 2022

Conversation

gopackgo90
Copy link
Contributor

@gopackgo90 gopackgo90 commented Dec 19, 2022 •
edited
Loading

Also fixed apicheck CI task and added additional testing for PyPy 3.9

@gopackgo90
Fix sphinx apicheck
ab9159a 
  ==============================
   Undocumented Autodoc Modules
  ==============================

  py
  --

  - django_celery_beat.signals
@gopackgo90
Add Python 3.11 support
b89f938
@gopackgo90
Add additional django testing for PyPy 3.9
d5776be
@gopackgo90 gopackgo90 changed the title Fix sphinx apicheck Add Python 3.11 support Dec 19, 2022
auvipy
auvipy requested changes Dec 19, 2022
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please check the py3.11 build failure please? there seems to be some distutils import issue

@gopackgo90
Copy link
Contributor Author

Yeah, I was looking at it a bit last night and wasn’t able to figure it out quickly. It’s choking on building the wheels for python-crontab and ephem. ephem has pre-built wheels for Python 3.10, but not 3.11. On my personal macOS I was able to build the wheels for both packages on Python 3.11 without issue, so it will take some more digging. If I can’t figure it out I’ll close this PR and make a new one with the other changes that do work, expanding PyPy/Django matrix testing and fixing the existing Sphinx apicheck.

auvipy
auvipy requested changes Dec 19, 2022
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the time being

.github/workflows/test.yml Outdated Show resolved Hide resolved
auvipy
auvipy requested changes Dec 19, 2022
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@gopackgo90 gopackgo90 changed the title Add Python 3.11 support Fix apicheck CI task and add additional testing for PyPy 3.9 Dec 19, 2022
@gopackgo90
Copy link
Contributor Author

I renamed this PR, I suppose we could just merge those changes in at least as this PR and maybe revisit Python 3.11 later.

@auvipy
Copy link
Member

auvipy commented Dec 19, 2022

yep

@auvipy auvipy merged commit 8f13041 into celery:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gopackgo90 @auvipy