fix/clarify update_changed after TZ change #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
approved these changes
Jul 15, 2024
|
Very nice, thanks for merging. Looking forward to a docs rebuild, so future people aren't confused by this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've stumbled over this on the docs website here.
The code example there will raise
TypeError: PeriodicTasks.changed() missing 1 required positional argument: 'instance', as that expects thePeriodicTaskinstance as an argument, probably in a for loop as in the Readme here.I've set it to
update_changed, I assume that will do the same as looping through the PeriodicTask instances and callingchangedon each?