Update test suite to use pytest, remove related in setup.py

[kwongtn]

Setuptools removes use of setuptools.command.test
This PR serves as a quick temporary fix.

Refer:

• https://setuptools.pypa.io/en/stable/history.html#v72-0-0

[wongjiahau]

Running poetry add git+https://github.com/kwongtn/django-celery-beat#restrict-setuptools-to-max-v71 still fails with the same error

[cclauss]

Nice initiative!! This is still happening on our GitHub Actions Py3.12 tests...

ModuleNotFoundError: No module named 'setuptools.command.test'

setuptools changelog: https://setuptools.pypa.io/en/stable/history.html#v72-0-0

In this repo:

django-celery-beat/Makefile

Line 142 in 8fe7836

$(PYTHON) setup.py test

[kwongtn]

If anyone wants to take over and continue fixing, please do so..
I'm out of ideas 😥

[paretosti]

@wongjiahau

Running poetry add git+https://github.com/kwongtn/django-celery-beat#restrict-setuptools-to-max-v71 still fails with the same error

Is this the right way to install a branch? Is it not

poetry add git+https://github.com/kwongtn/django-celery-beat/restrict-setuptools-to-max-v71

Edit: Sorry I think i must be missing something...

[shijl0925]

pip3 install django-celery-beat@git+https://github.com/kwongtn/django-celery-beat.git@fix/restrict-setuptools-to-max-v71

Collecting django-celery-beat@ git+https://github.com/kwongtn/django-celery-beat.git@fix/restrict-setuptools-to-max-v71
Cloning https://github.com/kwongtn/django-celery-beat.git (to revision fix/restrict-setuptools-to-max-v71) to /tmp/pip-install-otwx_qhh/django-celery-beat_a2925745ef8d482b967cd8ec9c642a08
Running command git clone --filter=blob:none --quiet https://github.com/kwongtn/django-celery-beat.git /tmp/pip-install-otwx_qhh/django-celery-beat_a2925745ef8d482b967cd8ec9c642a08
Running command git checkout -b fix/restrict-setuptools-to-max-v71 --track origin/fix/restrict-setuptools-to-max-v71
Switched to a new branch 'fix/restrict-setuptools-to-max-v71'
branch 'fix/restrict-setuptools-to-max-v71' set up to track 'origin/fix/restrict-setuptools-to-max-v71'.
Resolved https://github.com/kwongtn/django-celery-beat.git to commit 5a21c38
Installing build dependencies ... done
Getting requirements to build wheel ... error
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [20 lines of output]
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in
main()
File "/usr/local/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/in_process/in_process.py", line 118, in get_requires_for_build_wheel
return hook(config_settings)
^^^^^^^^^^^^^^^^^^^^^
File "/tmp/pip-build-env-i22alft/overlay/lib/python3.11/site-packages/setuptools/build_meta.py", line 327, in get_requires_for_build_wheel
return self.get_build_requires(config_settings, requirements=[])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/pip-build-env-i22alft/overlay/lib/python3.11/site-packages/setuptools/build_meta.py", line 297, in get_build_requires
self.run_setup()
File "/tmp/pip-build-env-i22alft/overlay/lib/python3.11/site-packages/setuptools/build_meta.py", line 497, in run_setup
super().run_setup(setup_script=setup_script)
File "/tmp/pip-build-env-i22alft/overlay/lib/python3.11/site-packages/setuptools/build_meta.py", line 313, in run_setup
exec(code, locals())
File "", line 123, in
NameError: name 'pytest' is not defined. Did you mean: 'bytes'?
[end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.

the code should be removed?

cmdclass={'test': pytest}

[kwongtn]

@shijl0925 Yup I think you're right -- removed it and it works nicely now

Not sure how it will affect the test in this repo tho 😅
But I replaced it for pytest to be called directly from terminal instead of being invoked by setup.py

I'll be locking my prod build to 65d5743 , but @cclauss feel free to make required edits

[cclauss]

Does make test work on your machine?

[kwongtn]

Unfortunately no, but tox does though

Although t/unit/test_schedulers.py::test_modeladmin_PeriodicTaskAdmin::test_run_task fail 😅

[cclauss]

Please try make test on your computer.

[cclauss]

@kwongtn. Awesome work! Thanks for doing this.

@Nusnus @auvipy We will need a new release to PyPI to cover the breaking change in setuptools.
Also see:

• setuptools >= v72 removes setuptools.command.test celery#9157