-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(db-scheduler): optimize all_as_schedule query #835
Conversation
…rying the database
…refactor all_as_schedule test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #835 +/- ##
==========================================
+ Coverage 87.20% 87.42% +0.21%
==========================================
Files 32 32
Lines 938 954 +16
Branches 76 76
==========================================
+ Hits 818 834 +16
Misses 102 102
Partials 18 18 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good from the first review. I will thoroughly Review it again in a couple of days before merging
I have also encountered performance issues when there are a large number of scheduled tasks. I addressed this in a straightforward manner by adding a However, it is evident that alirafiei75's solution is more ingenious. It not only addresses the performance issues but also effectively reduces the pressure on database queries. |
thanks for your work. feel free to contribute back if you find any better improvement or regression. |
Summary
This PR optimizes the
all_as_schedule
function to improve performance by filtering unnecessary tasks from the database query.Changes
fixes #675
fixes #786