Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow for custom states in status field #407

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: allow for custom states in status field #407

wants to merge 2 commits into from

Conversation

ericswpark
Copy link

From #366 (comment)

Thanks to @cdevacc1 for the idea. I just decided to write up the PR as it only takes a couple of minutes. This should resolve the bug where custom states are not shown at all in the admin panel.

@auvipy
Copy link
Member

auvipy commented Sep 4, 2023

And tests are already failing you can see that

@ericswpark
Copy link
Author

Yup, forgot to create DB migrations after the change. (unless it was failing for a different reason)

@ericswpark
Copy link
Author

@auvipy the tests should now pass with the added migration. Can I please request a review? Thanks!

@auvipy auvipy mentioned this pull request Jun 9, 2024
Merged
@ericswpark ericswpark requested a review from auvipy June 18, 2024 23:47
@ericswpark
Copy link
Author

@auvipy I'm not sure what breaking changes you're concerned about -- removing the line should allow for custom states while letting those who originally used the TASK_STATE_CHOICES for choices keep their data with no changes necessary. Please let me know if there's anything else you need or any other changes that should be made before the PR is merged or rejected. Thanks.

@ericswpark
fix: allow for custom states in status field
5919aeb 
From celery#366 (comment)

Thanks to @cdevacc1 for the idea. I just decided to write up the PR as
it only takes a couple of minutes. This should resolve the bug where
custom states are not shown at all in the admin panel.
@ericswpark
Create migrations
5b852d6
@ericswpark ericswpark requested a review from auvipy June 19, 2024 09:27
@ericswpark
Copy link
Author

@auvipy may this please be reviewed before it becomes stale? I'd like to avoid having to rebase it over and over and this PR's been sitting in my list since last year. Thanks!

@auvipy
Copy link
Member

auvipy commented Jun 25, 2024

@auvipy I'm not sure what breaking changes you're concerned about -- removing the line should allow for custom states while letting those who originally used the TASK_STATE_CHOICES for choices keep their data with no changes necessary. Please let me know if there's anything else you need or any other changes that should be made before the PR is merged or rejected. Thanks.

my only concern is if existing users are going to miss anything by the removal of the TASK_STATE_CHOICES

@ericswpark
Copy link
Author

my only concern is if existing users are going to miss anything by the removal of the TASK_STATE_CHOICES

Please see previous comments. It should not affect existing users as it only limits what choices can go inside the field. Removing it expands it to allow for other values, not just the ones in TASK_STATE_CHOICES.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy Awaiting requested review from auvipy

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericswpark @auvipy