-
-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kombu using deprecated importlib-metadata shims #1600
Comments
Hey @syaffers 👋, We also offer priority support for our sponsors. |
Ah I should've mentioned, this happened on my Python 3.7.13. Works with no issues on 3.8.13. |
I get a probably related problem on Python 3.7 with kombu 5.2.4 when importing directly from kombu:
I can confirm that reverting to importlib-metadata<5.0.0 works. |
Because, the fix for the kombu issue celery/kombu#1600 in only available in beta. Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Because, the fix for the kombu issue celery/kombu#1600 in only available in beta. Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Because, the fix for the kombu issue celery/kombu#1600 in only available in beta. Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Because, the fix for the kombu issue celery/kombu#1600 in only available in beta. Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
The `importlib-metadata` package had to be pinned below `5.0.0` due to incompatibility with most recent kombu. The pinning can be removing after upstream kombu has been patched. More details here: celery/kombu#1600
* Update Python versions in the ci workflow. * Bump `actions/setup-python` to v4. * Pin kombu on Python 3.12. Workaround for celery/kombu#1600 * Decouple "-dev" suffix from version list. * Update release matrix strategy. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> * Comment out 3.12 until it's fixed. --------- Co-authored-by: Jason R. Coombs <jaraco@jaraco.com> Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Hi devs,
I'm facing the following issue when importing kombu in my code. I've narrowed it down to the library
importlib-metadata
's most recent release. Here's how to reproduce it:source .venv/bin/activate
importlib-metadata
release 5.0.0 is installedpip freeze | grep importlib-metadata
kombu.entity
It is stated in the most recent release of the library (https://github.com/python/importlib_metadata/blob/v5.0.0/CHANGES.rst)
I can confirm kombu still works with the most recent release in v4 (e.g. 4.13.0).
Since this
importlib-metadata
release 5.0.0 is installed alongside a fresh kombu installation, this could be problematic for new users down the line. I'm suggesting to limit the version to <5.0.0 to ensure usability.The text was updated successfully, but these errors were encountered: