Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit requests<2.32.0 due to docker-py issue 3256 #2011

Merged
merged 4 commits into from
May 29, 2024
Merged

Limit requests<2.32.0 due to docker-py issue 3256 #2011

merged 4 commits into from
May 29, 2024

Conversation

Nusnus
Copy link
Member

@Nusnus Nusnus commented May 29, 2024 •
edited
Loading

Extracted from #2007 by @awmackowiak

Due to: docker/docker-py#3256

@Nusnus Nusnus mentioned this pull request May 29, 2024
Merged
@Nusnus Nusnus marked this pull request as ready for review May 29, 2024 17:27
@Nusnus
Copy link
Member Author

Nusnus commented May 29, 2024

Don’t tell me it breaks due to new rabbitmq image now 🤦‍♂️

@Nusnus
Copy link
Member Author

Nusnus commented May 29, 2024

Don’t tell me it breaks due to new rabbitmq image now 🤦‍♂️

Trying to limit requests and rabbitmq image separately: #2012

If it won’t work, it might need to be done in the same PR.

@Nusnus Nusnus marked this pull request as draft May 29, 2024 17:36
@Nusnus
Copy link
Member Author

Nusnus commented May 29, 2024

Don’t tell me it breaks due to new rabbitmq image now 🤦‍♂️

Trying to limit requests and rabbitmq image separately: #2012

If it won’t work, it might need to be done in the same PR.

Ok it didn’t work. Trying to do both in a single PR.

@Nusnus
Copy link
Member Author

Nusnus commented May 29, 2024

Don’t tell me it breaks due to new rabbitmq image now 🤦‍♂️

Trying to limit requests and rabbitmq image separately: #2012
If it won’t work, it might need to be done in the same PR.

Ok it didn’t work. Trying to do both in a single PR.

Reverted the rabbitmq limit and added the tox.ini changes from the #2007 PR (forgot to add it in the first place)

@Nusnus Nusnus marked this pull request as ready for review May 29, 2024 17:48
@Nusnus Nusnus merged commit eae7585 into celery:main May 29, 2024
16 checks passed
@Nusnus Nusnus deleted the hotfix branch May 29, 2024 18:21
@awmackowiak
Copy link
Contributor

@Nusnus I also tried to find a silver bullet for those dependency cycle versions... and I also failed.
I also agree that is a messy problem which generates serious tech dept :(
But I think is a fresh case so maybe quickly those dependent libraries will update requests as well as everybody does.

@Nusnus Nusnus mentioned this pull request May 30, 2024
Closed
Nusnus added a commit that referenced this pull request Jun 25, 2024
@Nusnus
Revert "Limit requests<2.32.0 due to docker-py issue 3256 (#2011)"
1a76a85 
This reverts commit eae7585.
@Nusnus Nusnus mentioned this pull request Jun 25, 2024
Merged
Nusnus added a commit that referenced this pull request Jun 25, 2024
@Nusnus
Reverted limiting requests<2.32.0 in requirements/default.txt but kep…
d05b4b0 
…t in tox.ini due to docker-py issue 3256 (#2041)

* Revert "Limit requests<2.32.0 due to docker-py issue 3256 (#2011)"

This reverts commit eae7585.

* Keep requests<2.32.0 limit in tox.ini

* Undo any change in tox.ini to have a clean PR
@max-wittig
Copy link

I was about to test https://github.com/celery/kombu/releases/tag/v5.4.0rc1, but sadly this prevents it as I don't feel like downgrading requests as 2.32.0 contains security fixes. To my understanding (maybe I'm wrong), requests was only downgraded to make sure that tests still work, right?

Couldn't this be just downgraded for the tests?

@Nusnus
Copy link
Member Author

Nusnus commented Jun 26, 2024

Couldn't this be just downgraded for the tests?

Yes, and it was already changed accordingly yesterday 🙂
#2041

@max-wittig
Copy link

@Nusnus Ahh okay! Sorry I've not seen that! So I will test the next pre-release 🙂 Thanks!

@Nusnus
Copy link
Member Author

Nusnus commented Jul 11, 2024

@max-wittig

@Nusnus Ahh okay! Sorry I've not seen that! So I will test the next pre-release 🙂 Thanks!

v5.4.0rc2 is out!
The requests package is no longer limited to <2.32.0 per #2041.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nusnus @awmackowiak @max-wittig