Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving TypeError, during version unpacking #2098

Merged
merged 8 commits into from
Aug 25, 2024
Merged

Resolving TypeError, during version unpacking #2098

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
680a371
- This will make sure that the version unpacking doesn't stop connect…
couzhei Aug 14, 2024
b8cf3ab
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 14, 2024
62355ce
- I updated the test in this version
couzhei Aug 19, 2024
3eec8df
Merge branch 'bugfix/type-error-version-checking' of https://github.c…
couzhei Aug 19, 2024
8e9d627
- Removed `merge-conflict` comments in the code!
couzhei Aug 19, 2024
26cac4a
- linting problem resolved.
couzhei Aug 19, 2024
bf35400
- Docstrings are now in accordance with `pydocstyle`.
couzhei Aug 21, 2024
c044dbe
- resolving `"_unpack_version" has incompatible type "int"` problem i…
couzhei Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions kombu/utils/text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from __future__ import annotations

from difflib import SequenceMatcher
from typing import Iterable, Iterator
from typing import Iterable, Iterator, Tuple

from kombu import version_info_t

Expand Down Expand Up @@ -59,7 +59,8 @@ def _unpack_version(
minor: str | int = 0,
micro: str | int = 0,
releaselevel: str = '',
serial: str = ''
serial: str = '',
*args: Tuple[str]
) -> version_info_t:
return version_info_t(int(major), int(minor), micro, releaselevel, serial)

Expand Down
Loading